-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent project generation if api failure pt2 #1635
Merged
spwoodcock
merged 16 commits into
hotosm:fix/stop-proj-generation
from
NSUWAL123:fix/stop-proj-gen-on-error
Jul 8, 2024
Merged
Prevent project generation if api failure pt2 #1635
spwoodcock
merged 16 commits into
hotosm:fix/stop-proj-generation
from
NSUWAL123:fix/stop-proj-gen-on-error
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦o fix/stop-proj-gen-on-error
* build: remove unnecessary tables via migration & simplify schema * refactor: remove references to removed tables in sqlalchemy models * build: add IF EXISTS to DROP COLUMN in migration * build: remove default columns from previous migration * fix(backend): minor fixes to HTTPException on endpoints
β¦ of access token to 1 hour (hotosm#1633)
β¦oj-gen-on-error
β¦oj-gen-on-error
github-actions
bot
added
docs
Improvements or additions to documentation
frontend
Related to frontend code
backend
Related to backend code
devops
Related to deployment or configuration
ODK
Any requests for optimizing ODK
migration
Contains a DB migration
labels
Jul 8, 2024
spwoodcock
changed the title
Fix/stop proj gen on error
Prevent project generation if api failure pt2
Jul 8, 2024
spwoodcock
added a commit
that referenced
this pull request
Jul 8, 2024
* fix(hotfix): download of basemaps in ui, max zoom level 22 used for tms * ci: update all gh-workflows to latest v1.6.0 * build: upgrade rclone --> v1 pin to avoid CVE-2024-24790 * build: remove unnecessary tables and field from db schema (#1623) * build: remove unnecessary tables via migration & simplify schema * refactor: remove references to removed tables in sqlalchemy models * build: add IF EXISTS to DROP COLUMN in migration * build: remove default columns from previous migration * fix(backend): minor fixes to HTTPException on endpoints * fix(backend): addded created date on the project response, set expiry of access token to 1 hour (#1633) * docs: add placeholder for axiom repo activity * fix(createProjectSlice): set generateProject & drawToggle status to default * feat(commonUtils): isStatusSuccess function add * test: get the detailed task history for a project (#1626) * build(backend): add async-lru dep, remove cpuinfo dep * fix: replace lru_cache with async for getting odk creds * fix(splitTasks): dependency add to useEffect * fix(createProjectService): halt project creation if api failure --------- Co-authored-by: spwoodcock <sam.woodcock@protonmail.com> Co-authored-by: Sam <78538841+spwoodcock@users.noreply.github.com> Co-authored-by: Sujan Adhikari <109404840+Sujanadh@users.noreply.github.com> Co-authored-by: Azhar Ismagulova <31756707+azharcodeit@users.noreply.github.com>
spwoodcock
added a commit
that referenced
this pull request
Jul 8, 2024
* fix(frontend): prevent project generation if api failure * Prevent project generation if api failure pt2 (#1635) * fix(hotfix): download of basemaps in ui, max zoom level 22 used for tms * ci: update all gh-workflows to latest v1.6.0 * build: upgrade rclone --> v1 pin to avoid CVE-2024-24790 * build: remove unnecessary tables and field from db schema (#1623) * build: remove unnecessary tables via migration & simplify schema * refactor: remove references to removed tables in sqlalchemy models * build: add IF EXISTS to DROP COLUMN in migration * build: remove default columns from previous migration * fix(backend): minor fixes to HTTPException on endpoints * fix(backend): addded created date on the project response, set expiry of access token to 1 hour (#1633) * docs: add placeholder for axiom repo activity * fix(createProjectSlice): set generateProject & drawToggle status to default * feat(commonUtils): isStatusSuccess function add * test: get the detailed task history for a project (#1626) * build(backend): add async-lru dep, remove cpuinfo dep * fix: replace lru_cache with async for getting odk creds * fix(splitTasks): dependency add to useEffect * fix(createProjectService): halt project creation if api failure --------- Co-authored-by: spwoodcock <sam.woodcock@protonmail.com> Co-authored-by: Sam <78538841+spwoodcock@users.noreply.github.com> Co-authored-by: Sujan Adhikari <109404840+Sujanadh@users.noreply.github.com> Co-authored-by: Azhar Ismagulova <31756707+azharcodeit@users.noreply.github.com> * build: update to latest ms playwright image v1.45.1 --------- Co-authored-by: Nishit Suwal <81785002+NSUWAL123@users.noreply.github.com> Co-authored-by: Sujan Adhikari <109404840+Sujanadh@users.noreply.github.com> Co-authored-by: Azhar Ismagulova <31756707+azharcodeit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Describe this PR
This PR is the continuation of PR #1627. This PR contains works to halt project creation if any of the project creation API fails.